Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
git-utils@v5.7.0 was published to the npm package registry without the submodule files included.
This occurs when running `npm publish`, after cloning this repository non-recursively (should be `git clone --recurse-submodules` (or `git clone --recurse` as a shorthand syntax)... or after cloning non-recursively, one should run `git submodule update --init`.
This brings in the submodule at `deps/libgit2`. Without these files included in the published tarball, the package lacks the library it is based around, and the package does not build or function -- the package is effectively broken if uploaded without the submodule included.
Steps to Reproduce
mkdir inspect_gitutils_tarball && cd inspect_gitutils_tarball
npm pack git-utils@5.7.0 (This downloads git-utils@v5.7.0 from the npm package registry)
tar xf git-utils-5.7.0.tgz (Unpack the tarball, wait for it to finish unpacking)
ls ./package (inspect the contents of the tarball, looking for the deps/libgit2 submodule files to be present)
Expected behavior:
% ls ./package-5.6.2
LICENSE.md appveyor.yml deps src
README.md binding.gyp package.json
Submodule should be included in the tarball; there should be files in deps/libgit2
Actual behavior:
% ls ./package-5.7.0
LICENSE.md appveyor.yml package.json
README.md binding.gyp src
Submodule is not included; there is no deps folder in the tarball.
Reproduces how often:
100% with v5.7.0
Versions
git-utils@v5.7.0
Additional Information
Please consider uploading a v5.7.1 with the submodule initialized. Also, consider https://github.com/atom/git-utils/pull/104 to make sure the submodule is automatically initialized before publishing this package. https://github.com/atom/git-utils/pull/104 or a similar approach would effectively prevent this issue from happening in the process of uploading future releases.
Prerequisites
Description
git-utils@v5.7.0
was published to the npm package registry without the submodule files included.Steps to Reproduce
mkdir inspect_gitutils_tarball && cd inspect_gitutils_tarball
npm pack git-utils@5.7.0
(This downloadsgit-utils@v5.7.0
from the npm package registry)tar xf git-utils-5.7.0.tgz
(Unpack the tarball, wait for it to finish unpacking)ls ./package
(inspect the contents of the tarball, looking for thedeps/libgit2
submodule files to be present)Expected behavior:
Submodule should be included in the tarball; there should be files in
deps/libgit2
Actual behavior:
Submodule is not included; there is no
deps
folder in the tarball.Reproduces how often:
100% with v5.7.0
Versions
git-utils@v5.7.0
Additional Information
Please consider uploading a v5.7.1 with the submodule initialized. Also, consider https://github.com/atom/git-utils/pull/104 to make sure the submodule is automatically initialized before publishing this package. https://github.com/atom/git-utils/pull/104 or a similar approach would effectively prevent this issue from happening in the process of uploading future releases.