search

atom / git-utils

Git Node Module
http://atom.github.io/git-utils
MIT License
166 stars 59 forks source link

Upgrade libgit2 to 0.24.2 #71

Closed niw closed 7 years ago

niw commented 8 years ago

To address #70, upgrade libgit2 to 0.24.0.

niw commented 8 years ago

Just tested this patch with Atom.app, still Atom.app may crash with other issue in libgit2 with git repository using index version 4. Even though, it might be good idea to have this patch to not crash git-utils by opening such git repository, however, this can't be a solution for atom/atom#11225.

niw commented 8 years ago

Updated libgit2 to 0.24.1. Sorry about the branch name that said 0.24.0. I can't change branch name to update this pull request.

tgandrews commented 7 years ago

There is now a 0.24.2 which fixes #73

niw commented 7 years ago

The commit 8dfc25b is a nasty workaround for the error occurs on Travis-CI environment, which is using npm 0.10 and clang-3.4. I'm not sure if we should have this commit or not, but to make things green, I put it for now.

tgandrews commented 7 years ago

What can I do to help test this?

rossburton commented 7 years ago

I really need this to merge as due to our .gitignore layout I can't use cmd-p at all thanks to #73. Who do I need to send beer/coffee/flowers to?

50Wliu commented 7 years ago

I've notified the team.

damieng commented 7 years ago

We should bump this to 0.24.3 to address the CVE issues reported on libgit2.