search

atom / git-utils

Git Node Module
http://atom.github.io/git-utils
MIT License
166 stars 59 forks source link

.gitignore cascaded negations #93

Open oomathias opened 5 years ago

oomathias commented 5 years ago

This is not really an issue. I'm just linking issues to make sure it's going to be fixed. Please delete this issue if it's not required.

Atom has weird behavior with cascaded ignore, like described here: https://github.com/atom/tree-view/issues/196#issuecomment-478982049

I went to test with libgit2 and found some bug. Some of these are already fixed in the latest version. Some will be in the next release: https://github.com/libgit2/libgit2/pull/5020, https://github.com/libgit2/libgit2/pull/5040

These fixes might be able to close the 5y old tree-view issue. But, we need to ensure that Atom passes a trailing slash when checking for a directory. (I didn't check that part in the code, maybe it's already the case).

50Wliu commented 5 years ago

Thanks for the update @oomathias! We updated to a more recent version of libgit2 recently and plan to update to the next version as per #92.