Atom lost my GH password, will not let me log back in

[cj2001]

Description

Fellow Hubber here. I upgraded to OS X High Sierra this weekend and all of the sudden Atom can't seem to figure out who I am. At first, I was having this exact problem. So I went with the instructions, closed down Atom, and did brew install git. Now, the error message has changed. I tried pulling a repo that I have rights to and I get remote: Invalid username or password. I use a password manager and I have not changed my GH password. Further, I can log in to the actual site when not using Atom as well as use the GH desktop.

Thoughts?

Version Info:

atom --version Atom : 1.22.1 Electron: 1.6.15 Chrome : 56.0.2924.87 Node : 7.4.0

git 2.15.0

[cj2001]

Update:

When I ran git --version, I got the following error:

xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun

I also received this error when I tried to run git config --get-all credential.helper. After googling, I found out that I needed to run xcode-select --install (which seems to sometimes be required after an OS upgrade). After doing so, I get the following for git --version:

git version 2.13.6 (Apple Git-96)

and I also get

git config --get-all credential.helper osxkeychain osxkeychain

(there are two of them.) . I still get the invalid username/PW error, but thought I would add this note for completeness on what I have tried.

[rsese]

Hey @cj2001 :wave:

About this error:

When I ran git --version, I got the following error:

xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun

Looks like installing the Xcode dev tools should fix the error?

https://apple.stackexchange.com/questions/254380/macos-sierra-invalid-active-developer-path

Also just to confirm, you're not getting prompted for credentials correct? If so, do you remember if you're using a personal access token for your password?

[cj2001]

Update

I paired with @robrix on this one. I am using an access token and we generated a new one. However, we kept getting the error. I did xcode-select --install and git config --get-all credential.helper and these came back fine.

Eventually, we tried a whole bunch of things and could not get it to like my login information. As a last ditch effort, @robrix suggested rebooting (stating it was unlikely to fix anything). On reboot, I got a message from OS X stating it was still installing things...that was weird because it claimed to have completed before. But once that reboot completed, it accepted my token and let me back into my repos.

It was very strange and I am not at all an expert in it. @robrix, maybe you can provide an accurate / technically-worded explanation of what you saw?

[robrix]

In the course of this, the calls to the security tool were failing, so atom-github wasn’t able to actually write the credentials to the keychain at all (or, presumably, read them back out). My best guess at this point was that OS X hadn’t finished the upgrade but had somehow (it is a mystery 👻) allowed @cj2001 to login and run as normal despite that fact. If so, that would indicate that this was an OS X issue, but it still might be worth having atom-github not just swallow the errors from the security process (we found them by opening the dev tools in Atom when clicking the login button after pasting the new token in—they weren’t otherwise visible in the UI, the button just appeared to do nothing).

[rsese]

Thanks for all the details of your sleuthing 🔍, glad you're up and running @cj2001 🙌

but it still might be worth having atom-github not just swallow the errors from the security process (we found them by opening the dev tools in Atom when clicking the login button after pasting the new token in—they weren’t otherwise visible in the UI, the button just appeared to do nothing).

You don't happen to remember what some of those errors were? Or are they still available in dev tools so you can copy/paste?

[robrix]

You don't happen to remember what some of those errors were? Or are they still available in dev tools so you can copy/paste?

I do not, alas 😞 and they would’ve been lost when @cj2001 rebooted, I think. Sorry for the lapse, that’s totally my bad 😕

[joshaber]

FWIW, we've had reports on GitHub Desktop of users keychains being in a weird state after upgrading to High Sierra. Having them lock and unlock their keychain seems to fix it 🤷‍♂️