search

atom / github

:octocat: Git and GitHub integration for Atom
https://github.atom.io
MIT License
1.12k stars 393 forks source link

remote host key verification #1316

Open hintss opened 6 years ago

hintss commented 6 years ago

Minor UI issue, when pushing to a host not in the known_hosts, you're prompted for the "would you like to trust this host? (yes/no)", however, the prompt appears to be a prompt meant for entering passwords.

image

rsese commented 6 years ago

Thanks for the report @hintss, I can reproduce on macOS 10.12.6 with Atom 1.26.0-dev-b42972fa8 - for some git repository:

  1. Change the remote to use the repo SSH URL e.g. git remote set-url git@github.com:user/repo.git
  2. Temporarily rename your known_hosts file: mv ~/.ssh/known_hosts ~/.ssh/known_hosts.tmp
  3. Make a change in some file, stage it, then commit it
  4. Push

Maybe expect to see no Password: title for the text input or yes/no buttons, actual behavior is you see the screenshot above.

Thanks again for the report - as a side note, if you can fill out the issue template as much as possible, that would be super helpful for us.