Github package does not show diffs

kryten87 commented 6 years ago

Prerequisites

Have you tried to reproduce the problem in Safe Mode? yes
Have you followed all applicable steps in the debugging guide? yes
Have you checked the FAQs on the message board for common solutions? yes
Have you checked that your issue isn't already filed? yes

Description

Brand new installation of Atom on a brand new installation of Ubuntu 18.04 with all updates applied.

Atom : 1.31.2 Electron: 2.0.7 Chrome : 61.0.3163.100 Node : 8.9.3

Steps to Reproduce

Open project Change file Click on file in "Unstaged Changes" pane

Expected behavior:

See diff in main editor area

Actual behavior:

Nothing

Reproduces how often:

Always.

Versions

Ubuntu 18.04.1, just installed on a brand new SSD drive yesterday.

Atom : 1.31.2 Electron: 2.0.7 Chrome : 61.0.3163.100 Node : 8.9.3

FWIW, I also installed 1.31.0, 1.30.0, and 1.29.0 and they're all doing the same thing.

Additional Information

There are no messages in the Chrome developer console or on the command line.

kryten87 commented 6 years ago

Interestingly, I got it to work by doing a clean install from the repository (as opposed to the .deb file), but it stopped working as soon as I installed the packages I want to use (and no, it still does not work with atom --safe)

annthurium commented 6 years ago

@Kryten0807 thanks for reporting!

Can you let me know what other packages you've got installed? You can find this out by running apm ls in any terminal.

kryten87 commented 6 years ago

Sorry, I've uninstalled the latest version of atom, so I can't report on packages installed right now. However, I first observed this problem with a brand new install, with no packages installed.

I've rolled my Atom installation back to 1.27.2, which was what I was using before I replaced my hard drive yesterday. I'm going to step through the installation of my favorite packages & see if it breaks. I'll report back when I'm done.

kryten87 commented 6 years ago

Further observations:

I rolled back my installation to 1.27.2 and everything worked. I then stepped through and added back the packages I had installed before and everything worked.

Next, I removed 1.27.2 (apt-get purge atom) and installed 1.28.2 and it stopped working. This is before I installed any community packages and this is true for both normal and safe mode. Here's the version info and package list for my basic 1.28.2 installation:

Atom : 1.28.2 Electron: 2.0.5 Chrome : 61.0.3163.100 Node : 8.9.3

Built-in Atom Packages (92) ├── atom-dark-syntax@0.29.0 ├── atom-dark-ui@0.53.2 ├── atom-light-syntax@0.29.0 ├── atom-light-ui@0.46.2 ├── base16-tomorrow-dark-theme@1.5.0 ├── base16-tomorrow-light-theme@1.5.0 ├── one-dark-ui@1.12.3 ├── one-light-ui@1.12.3 ├── one-dark-syntax@1.8.2 ├── one-light-syntax@1.8.2 ├── solarized-dark-syntax@1.1.4 ├── solarized-light-syntax@1.1.4 ├── about@1.9.1 ├── archive-view@0.64.6 ├── autocomplete-atom-api@0.10.7 ├── autocomplete-css@0.17.5 ├── autocomplete-html@0.8.4 ├── autocomplete-plus@2.40.6 ├── autocomplete-snippets@1.12.0 ├── autoflow@0.29.4 ├── autosave@0.24.6 ├── background-tips@0.28.0 ├── bookmarks@0.45.1 ├── bracket-matcher@0.89.2 ├── command-palette@0.43.5 ├── dalek@0.2.2 ├── deprecation-cop@0.56.9 ├── dev-live-reload@0.48.1 ├── encoding-selector@0.23.9 ├── exception-reporting@0.43.1 ├── find-and-replace@0.215.11 ├── fuzzy-finder@1.8.2 ├── github@0.15.5 ├── git-diff@1.3.9 ├── go-to-line@0.33.0 ├── grammar-selector@0.50.1 ├── image-view@0.62.4 ├── incompatible-packages@0.27.3 ├── keybinding-resolver@0.38.1 ├── line-ending-selector@0.7.7 ├── link@0.31.4 ├── markdown-preview@0.159.20 ├── metrics@1.2.6 ├── notifications@0.70.5 ├── open-on-github@1.3.1 ├── package-generator@1.3.0 ├── settings-view@0.254.2 ├── snippets@1.3.3 ├── spell-check@0.73.4 ├── status-bar@1.8.15 ├── styleguide@0.49.11 ├── symbols-view@0.118.2 ├── tabs@0.109.2 ├── timecop@0.36.2 ├── tree-view@0.222.0 ├── update-package-dependencies@0.13.1 ├── welcome@0.36.6 ├── whitespace@0.37.5 ├── wrap-guide@0.40.3 ├── language-c@0.59.5 ├── language-clojure@0.22.7 ├── language-coffee-script@0.49.3 ├── language-csharp@1.0.4 ├── language-css@0.42.10 ├── language-gfm@0.90.4 ├── language-git@0.19.1 ├── language-go@0.45.3 ├── language-html@0.49.1 ├── language-hyperlink@0.16.3 ├── language-java@0.29.0 ├── language-javascript@0.128.7 ├── language-json@0.19.2 ├── language-less@0.34.2 ├── language-make@0.22.3 ├── language-mustache@0.14.5 ├── language-objective-c@0.15.1 ├── language-perl@0.38.1 ├── language-php@0.43.2 ├── language-property-list@0.9.1 ├── language-python@0.49.5 ├── language-ruby@0.71.4 ├── language-ruby-on-rails@0.25.3 ├── language-sass@0.62.0 ├── language-shellscript@0.26.3 ├── language-source@0.9.0 ├── language-sql@0.25.10 ├── language-text@0.7.4 ├── language-todo@0.29.4 ├── language-toml@0.18.2 ├── language-typescript@0.3.3 ├── language-xml@0.35.2 └── language-yaml@0.32.0

Community Packages (0) /home/dthomas/.atom/packages └── (empty)

Finally, I rolled back to 1.27.2 again and it worked, both before and after I installed my packages. Here are the details of the working installation:

Atom : 1.27.2 Electron: 1.7.15 Chrome : 58.0.3029.110 Node : 7.9.0

Built-in Atom Packages (92) ├── atom-dark-syntax@0.29.0 ├── atom-dark-ui@0.53.2 ├── atom-light-syntax@0.29.0 ├── atom-light-ui@0.46.2 ├── base16-tomorrow-dark-theme@1.5.0 ├── base16-tomorrow-light-theme@1.5.0 ├── one-dark-ui@1.12.1 ├── one-light-ui@1.12.1 ├── one-dark-syntax@1.8.2 ├── one-light-syntax@1.8.2 ├── solarized-dark-syntax@1.1.4 ├── solarized-light-syntax@1.1.4 ├── about@1.8.1 ├── archive-view@0.64.3 ├── autocomplete-atom-api@0.10.7 ├── autocomplete-css@0.17.5 ├── autocomplete-html@0.8.4 ├── autocomplete-plus@2.40.6 ├── autocomplete-snippets@1.12.0 ├── autoflow@0.29.3 ├── autosave@0.24.6 ├── background-tips@0.28.0 ├── bookmarks@0.45.1 ├── bracket-matcher@0.89.2 ├── command-palette@0.43.5 ├── dalek@0.2.2 ├── deprecation-cop@0.56.9 ├── dev-live-reload@0.48.1 ├── encoding-selector@0.23.8 ├── exception-reporting@0.43.1 ├── find-and-replace@0.215.9 ├── fuzzy-finder@1.8.1 ├── github@0.14.5 ├── git-diff@1.3.9 ├── go-to-line@0.33.0 ├── grammar-selector@0.50.1 ├── image-view@0.62.4 ├── incompatible-packages@0.27.3 ├── keybinding-resolver@0.38.1 ├── line-ending-selector@0.7.6 ├── link@0.31.4 ├── markdown-preview@0.159.20 ├── metrics@1.2.6 ├── notifications@0.70.5 ├── open-on-github@1.3.1 ├── package-generator@1.3.0 ├── settings-view@0.254.2 ├── snippets@1.3.3 ├── spell-check@0.73.4 ├── status-bar@1.8.15 ├── styleguide@0.49.11 ├── symbols-view@0.118.2 ├── tabs@0.109.1 ├── timecop@0.36.2 ├── tree-view@0.222.0 ├── update-package-dependencies@0.13.1 ├── welcome@0.36.6 ├── whitespace@0.37.5 ├── wrap-guide@0.40.3 (disabled) ├── language-c@0.59.3 ├── language-clojure@0.22.7 ├── language-coffee-script@0.49.3 ├── language-csharp@1.0.1 ├── language-css@0.42.10 ├── language-gfm@0.90.3 ├── language-git@0.19.1 ├── language-go@0.45.3 ├── language-html@0.49.0 ├── language-hyperlink@0.16.3 ├── language-java@0.29.0 ├── language-javascript@0.128.5 ├── language-json@0.19.1 ├── language-less@0.34.2 ├── language-make@0.22.3 ├── language-mustache@0.14.5 ├── language-objective-c@0.15.1 ├── language-perl@0.38.1 ├── language-php@0.43.2 ├── language-property-list@0.9.1 ├── language-python@0.49.5 ├── language-ruby@0.71.4 ├── language-ruby-on-rails@0.25.3 ├── language-sass@0.61.4 ├── language-shellscript@0.26.3 ├── language-source@0.9.0 ├── language-sql@0.25.10 ├── language-text@0.7.4 ├── language-todo@0.29.4 ├── language-toml@0.18.2 ├── language-typescript@0.3.3 ├── language-xml@0.35.2 └── language-yaml@0.32.0

Community Packages (16) /home/dthomas/.atom/packages ├── aligner@1.2.4 ├── aligner-css@1.2.1 ├── aligner-javascript@1.3.0 ├── aligner-php@1.2.0 ├── aligner-scss@1.3.1 ├── atom-jade@0.3.0 ├── busy-signal@1.4.3 ├── docblockr@0.13.7 ├── intentions@1.1.5 ├── linter@2.2.0 ├── linter-eslint@8.4.1 ├── linter-ui-default@1.7.1 ├── multi-wrap-guide@1.1.6 ├── open-this@0.5.0 ├── react@0.18.0 └── sort-lines@0.18.0

clement-leprovost commented 6 years ago

I've had the same problem for months, and none of the usual tricks (safe mode, disabling other packages, changing package settings...) could make it work. Until today when, by sheer accident, I docked my Git tab to the right of my workspace, instead of the bottom... and suddenly the diff view was working again! I tried docking it back to the bottom: it stopped working. This is very deterministic.

Happy to help with any information (packages, settings...) if you need. Oh, and I love Atom. ;)

laughedelic commented 5 years ago

Oh my! I was struggling with this for so long time and just because I had the panel at the bottom! Thanks @clement-leprovost!

kryten87 commented 5 years ago

This issue persists in Atom 1.33.0. I just updated my system and Atom was automatically updated from the repository. Once all the updates were complete and I restarted my system, this issue reappeared.

I have rolled back to 1.27.2 again and I'm locking it at that version.

annthurium commented 5 years ago

@Kryten0807 sorry you're still having trouble.

Did you try docking the git pane at the right of the workspace instead of the bottom, as other commenters have suggested?

kryten87 commented 5 years ago

@annthurium Yes.

Opening the tab for the first time after upgrade, Git pane is on the right and works correctly.

Move Git pane to bottom of window, diff view does not work.

Move Git pane back to the right, diff view works again.

atom / github