Message template does not ignore commented lines like Git does - Githubissues

atom / github

:octocat: Git and GitHub integration for Atom

https://github.atom.io

MIT License

1.11k stars 392 forks source link

Message template does not ignore commented lines like Git does #1817

Closed lee-dohm closed 5 years ago

lee-dohm commented 5 years ago

Prerequisites

Have you tried to reproduce the problem in Safe Mode?
Have you followed all applicable steps in the debugging guide?
Have you checked the FAQs on the message board for common solutions?
Have you checked that your issue isn't already filed?

Description

Comment lines are included in the commit message upon commit when your ~/.gitmessage file contains commented lines.

Steps to Reproduce

Create a ~/.gitmessage file that contains two blank lines followed by two lines starting with a # character
Execute the command touch test from the command-line inside a Git repository
Launch Atom in Safe Mode
Open the Git panel
Double-click the test file in the Unstaged Changes panel
Type foo in the first line of the Git commit message box
Click "Commit to master"
Go back to the command line and execute git log -1

Expected behavior:

The commit comment text to consist only of foo

Actual behavior:

The commit comment contains foo, the blank line, and the two following commented lines

Reproduces how often:

100%

Versions

Atom    : 1.35.0-nightly2
Electron: 2.0.14
Chrome  : 61.0.3163.100
Node    : 8.9.3

Additional Information

I haven't tested other configurations of commented and uncommented lines (such as starting with comments and then having blank lines)
My ~/.gitmessage file is symlinked to my dotfiles directory (though I hope that won't make a difference)

annthurium commented 5 years ago

just merged https://github.com/atom/github/pull/1902 which should resolve this