atom / github

:octocat: Git and GitHub integration for Atom
https://github.atom.io
MIT License
1.12k stars 395 forks source link

[WIP] don't call method of destroyed webContents #2722

Open icecream17 opened 3 years ago

icecream17 commented 3 years ago

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

Description of the Change

The ubuntu tests have been failing, even for perfectly valid prs

One of the complained errors says "Attempting to call a function in a renderer window that has been closed or released." EDIT: This appears in all the tests, so this error (or warning?) doesn't actually fail the tests

So I think this attempt removes the function call - and hopefully fixes the tests

Screenshot or Gif

image

Applicable Issues

codecov[bot] commented 3 years ago

Codecov Report

Merging #2722 (c9ecdfe) into master (2053290) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
+ Coverage   93.46%   93.47%   +0.01%     
==========================================
  Files         237      237              
  Lines       13213    13213              
  Branches     1900     1900              
==========================================
+ Hits        12349    12351       +2     
+ Misses        864      862       -2     
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 100.00% <0.00%> (+0.18%) :arrow_up:
lib/atom/gutter.js 92.85% <0.00%> (+2.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2053290...c9ecdfe. Read the comment docs.

icecream17 commented 3 years ago

Okay, everything still seems to be the same....