atom / github

:octocat: Git and GitHub integration for Atom
https://github.atom.io
MIT License
1.12k stars 394 forks source link

Don't use deprecated `Buffer` #2724

Closed icecream17 closed 3 years ago

icecream17 commented 3 years ago

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

Description of the Change

According to https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/, Buffer(number) should be replaced by Buffer.alloc(number)

Screenshot or Gif

image

Applicable Issues

codecov[bot] commented 3 years ago

Codecov Report

Merging #2724 (1d6057d) into master (2053290) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2724   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         237      237           
  Lines       13213    13213           
  Branches     1900     1900           
=======================================
  Hits        12349    12349           
  Misses        864      864           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2053290...1d6057d. Read the comment docs.