Open icecream17 opened 2 years ago
Merging #2731 (02e6dda) into dependabot/npm_and_yarn/marked-4.0.10 (b5629b6) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dependabot/npm_and_yarn/marked-4.0.10 #2731 +/- ##
=========================================================================
+ Coverage 93.43% 93.47% +0.04%
=========================================================================
Files 237 237
Lines 13213 13212 -1
Branches 1900 1900
=========================================================================
+ Hits 12345 12350 +5
+ Misses 868 862 -6
Impacted Files | Coverage Δ | |
---|---|---|
lib/helpers.js | 89.25% <100.00%> (+0.36%) |
:arrow_up: |
lib/git-shell-out-strategy.js | 100.00% <0.00%> (+0.18%) |
:arrow_up: |
lib/controllers/reviews-controller.js | 100.00% <0.00%> (+1.75%) |
:arrow_up: |
lib/views/github-dotcom-markdown.js | 100.00% <0.00%> (+1.85%) |
:arrow_up: |
lib/atom/gutter.js | 92.85% <0.00%> (+2.38%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b5629b6...02e6dda. Read the comment docs.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Copied from https://github.com/icecream17/github/pull/2
Actually updating to v4.0.10 The only relevant breaking change: https://github.com/markedjs/marked/releases/tag/v4.0.0 is that the default export is removed:
({marked} = require('marked'))
Parens are required to make it not a SyntaxError.
Only other change is that the docs: https://marked.js.org/using_advanced recommend using sanitize on the output instead of in the options
The tests should pass (except for the ones that failed in https://github.com/atom/github/pull/2724): https://github.com/icecream17/github/pull/2
Although I don't know why there's more coverage
Screenshot or Gif
Applicable Issues