atom / github

:octocat: Git and GitHub integration for Atom
https://github.atom.io
MIT License
1.12k stars 394 forks source link

Explicitly set contextIsolation to false #2789

Open bongnv opened 2 years ago

bongnv commented 2 years ago

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

Description of the Change

Since Electron 12, the default of contextIsolation is changed to true from false so we'll have to set it to false. Otherwise, Node APIs won't be used in renderer processes.

See https://github.com/electron/electron/issues/23506 for more information.

Screenshot or Gif

N/A

Applicable Issues

N/A