Highlights can get into infinite loop, leaking memory under Linux

atom / highlights

Syntax highlighter

https://atom.github.io/highlights

MIT License

530 stars 54 forks source link

Highlights can get into infinite loop, leaking memory under Linux #35

Open pcarrier opened 8 years ago

pcarrier commented 8 years ago

Note that this does not happen under OSX. I suspect node-oniguruma handles Unicode differently somehow.

To reproduce:

Create breaks.js or breaks.rb (for example), with the bytes 0x27 0xc3 0xbc 0x27 (base64 J8O8Jw==), which looks like 'ü'.
Call the highlights command line utility on it. It never returns and its memory usage grows over time.

pcarrier commented 8 years ago

Please note that for server-side uses of highlights and whenever user-provided data is highlighted (eg through marky-markdown), this is a security issue as it allows DoS.