search

atom / highlights

Syntax highlighter
https://atom.github.io/highlights
MIT License
530 stars 54 forks source link

Stack traces when using the lib #40

Open felixsanz opened 8 years ago

felixsanz commented 8 years ago

Is this library still used by Atom and actively developed? Because last commit is from last year...

Anyway, the issue is about an error appearing. If you npm install it and just use the basic example from readme, you get C/JS stack traces.

And also this warning:

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.
heyimalex commented 8 years ago

This is related to this issue and kind of depends on first-mate (which seems equally inactive) to update its dependency on oniguruma. I'm not super familiar with shrinkwraping but a hacky solution is to add an npm-shrinkwrap.json file that looks like this:

{
  "dependencies": {
    "highlights": {
      "version": "1.3.1",
      "dependencies": {
        "first-mate": {
          "version": "5.1.1",
          "dependencies": {
            "oniguruma": {
              "version": "6.1.0"
}}}}}}}
ashleygwilliams commented 7 years ago

this just landed in first-mate 6.0.0 https://github.com/atom/first-mate/pull/74