search

atom / highlights

Syntax highlighter
https://atom.github.io/highlights
MIT License
529 stars 54 forks source link

fix: update first-mate #44

Closed ashleygwilliams closed 8 years ago

ashleygwilliams commented 8 years ago

fixes #46 and #40

ashleygwilliams commented 8 years ago

ok nevermind, my local copy just seems messed up. hey @bcoe could i get a review?

ashleygwilliams commented 8 years ago

just to note: my local tests fail 6 times, expects class="source coffee" gets class="text plain null-grammar" for each

zeke commented 8 years ago

my local tests fail 6 times

Hmm I wonder why it's not failing on Travis. I will run it locally too. Are you using node 6, @ashleygwilliams?

ashleygwilliams commented 8 years ago

@zeke i tested with 4, 5, and 6

bcoe commented 8 years ago

@ashleygwilliams, unless @zeke tests/lands first, I'll also happily run this on a few node versions tonight, and release to a next branch so that we can run our smoke-test follower against it.

zeke commented 8 years ago

I'm getting the following errors on node 6.3.1:

Running "shell:test" (shell) task
....FF..F....FF..F

All the output: https://gist.github.com/zeke/bb13e228ba2b1ec3f6b7bc5020524ad3

ashleygwilliams commented 8 years ago

this is the exact same problem i'm having @zeke. wonder why travis isn't catching it?

bcoe commented 8 years ago

@ashleygwilliams @zeke tests are looking great on my end:

https://gist.github.com/bcoe/3349791bc03ae6df3df0d86ea8decc87

I did have to submodule init, and ./node_modules/.bin/grunt prepublish; I know @ashleygwilliams tried this yesterday, and was still running into trouble -- I'm confused.