search

atom / ide-json

MIT License
24 stars 15 forks source link

fix: Rename server name #6

Closed Xapphire13 closed 5 years ago

Xapphire13 commented 6 years ago

Currently, when there is an error in a json file, the overlay states the error is coming from VSCode, this is a rather odd user experience since we're not consciously running anything to do with VSCode and the user only knows about the package as ide-json

image

Xapphire13 commented 6 years ago

@thomasjo, that totally makes sense. I think option 2 or 3 will lead to a better UX. Which do you lean toward? My thoughts:

Option 2: This seems the be the most accurate, although having VSCode in it just feels odd. Option 3: This would probably lead to the best UX (IMO), however it is disregarding the full name; I'm not sure how close to the full name you want to stick.

rwatts3 commented 6 years ago

I agree with both options 2 and 3 although I do see a valid point in keeping VSCode in the name so that the user can know more detail about who the provider is.

thomasjo commented 6 years ago

I'm thinking we should probably go with the full VSCode JSON Language Server, but let's get some more feedback on this.

/cc @atom/feedback

daviwil commented 6 years ago

VSCode JSON Language Server seems too long to me but I can't think of a shortening of it that doesn't cause it to lose information. I think it's fine to go with that!

thomasjo commented 6 years ago

VSCode JSON Language Server seems too long to me but I can't think of a shortening of it that doesn't cause it to lose information. I think it's fine to go with that!

Yeah, it's horribly long. I was thinking of suggesting VSCode JLS earlier, but it might be too cryptic 🤔

daviwil commented 6 years ago

Yep, even VSCode JSON LS seems too vague to me so I think the full name is the clearest option.

Xapphire13 commented 6 years ago

If you want to choose something for shortening, VSCode is often referred to as simply VSC, buys us a whole 3 characters =]

rwatts3 commented 6 years ago

So VSC JSON LSP might work On Thu, May 24, 2018 at 2:39 PM Steven notifications@github.com wrote:

If you want to choose something for shortening, VSCode is often referred to as simply VSC, buys us a whole 3 characters =]

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/atom/ide-json/pull/6#issuecomment-391871705, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFsSb-FxMpATbpD2C61PT58q0I0oKszks5t1yiUgaJpZM4ULq_e .

--

-V/R

Ryan Watts

<div class="LI-profile-badge" data-version="v1" data-size="medium" data-locale="en_US" data-type="horizontal" data-theme="light" data-vanity="ryandwatts">Ryan Watts

Xapphire13 commented 6 years ago

Any consensus on this? I have changed the PR text to VSC JSON Language Server