atom / ide-typescript

TypeScript and Javascript language support for Atom-IDE
MIT License
368 stars 63 forks source link

Upgrade typescript version to support new language features #158

Closed mneumark closed 3 years ago

mneumark commented 5 years ago

Prerequisites

Description

I tried to use a typescript feature that resulted in an error. Upon further research I realized its because this package uses typescript 3.1.6 and the feature I want got added in typescript 3.4.

Can we upgrade the version of typescript this package uses?

Steps to Reproduce

  1. create a file with a typescript const. Something like
    const foo = { bar: 'baz', hello: 'world' } as const 
  2. Notice an error pops up saying Cannot find name "const"

Expected behavior: No error should occur. This is now a standard feature of typescript.

Actual behavior: An error is occuring on perfectly valid typescript

Reproduces how often: 100% of the time

Versions

Atom 1.39.1 on macOS ide-typescript 0.9.1

mattlyons0 commented 5 years ago

As a temporary workaround you can install a newer version of the typescript language server globally (npm install -g typescript) and go into the extension settings for ide-typescript and change the language server path to where tsserver was installed. You can find where it is installed by typing in a terminal window which tsserver (which was /usr/bin/tsserver for me on Linux).

AlexGustafsson commented 4 years ago

Do you happen to know if this adds support for BigInt syntax such as 345689754387345678n?

mattlyons0 commented 4 years ago

It looks like Typescript 3.2 added support for BigInt, upgrading the tsserver binary used to 3.2 or newer should add support for it.