search

atom / ide-typescript

TypeScript and Javascript language support for Atom-IDE
MIT License
368 stars 63 forks source link

Bump TSServer & Theia Version #160

Closed mattlyons0 closed 3 years ago

mattlyons0 commented 5 years ago

New versions of TSServer when paired with Theia's language server include some very useful features (most notably it now seems to download types for node packages in the background now).

I've tested this throughout various JS repos and have not noticed any regressions.

The reason for the Theia (typescript-language-server) semvar major bump is because the package bumped monaco-languageclient which now is written in ES6.

Old:

image

image

New:

image

This fixes #158. This affects #144 by making its impact less widespread (any package with typings will no longer show the warning).

eaviles commented 4 years ago

@damieng, @50Wliu, would love to have this one out soon. I see errors in Node.js that I don't see in VSCode that would be solved with this PR.

FDiskas commented 4 years ago

And what are you waiting for?

FDiskas commented 4 years ago

And also why not to use project based typescript version?

damieng commented 4 years ago

I left GitHub over two years ago and stopped working on Atom and Atom IDE. While I can no longer speak for GitHub I think the fact they announced they were ceasing work on Atom IDE at the end of 2018 and there's not been any activity at all on this repo in over a year should tell you why.

bennypowers commented 4 years ago

@damieng I understand that you're not involved with atom development at the moment. Is there anyone else you can pass the baton to? There are still plenty of Atom users who would love to see this relatively straightforward PR land and release.

icecream17 commented 3 years ago

pinging @darangi (sorry if i'm pinging too much. - No one at https://github.com/atom/ide-typescript/graphs/contributors contributes to atom today, but since you're under https://github.com/orgs/atom/people you probably have access to merge this pr)

damieng commented 3 years ago

@icecream17 there is an alternative community-maintained package over at https://github.com/atom-community/atom-ide-javascript you might have more success with.