fix: false-positive error 'ts server not found' if project wasn't open

vlad0337187 commented 3 years ago

Requirements for Contributing a Bug Fix

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

Didn't create new issue, because this is realted to changes, made in: https://github.com/atom/ide-typescript/issues/154 If to open project without locally specified TS server path, it will show error alert. Also if to open project with locally specified TS server path, it'll show error alert anyway, because project path is not always set.

Description of the Change

Just check that path doesn't exist and do nothing. Also did a little refactor for already added code.

Alternate Designs

just a fix

Possible Drawbacks

Didn't find such, use this fix locally for near one month.

Verification Process

Use this plugin with my typescript project near one month.

Release Notes

vlad0337187 commented 3 years ago

Fixed found caused by recent PR issue. If anybody will have some time to review and merge - would be grateful =)

@Aerijo @damieng @darangi @jasonrudolph @dmleong @daviwil

vlad0337187 commented 3 years ago

Sorry for pinging about this. Just wanna leave a notification.

@Aerijo @damieng @darangi @jasonrudolph @dmleong @daviwil

damieng commented 3 years ago

Please stop "pinging" everybody who ever contributed to this repo. This project was discontinued by github and most of the people on your list are no longer involved or have access.

Darangi is seemingly the only active contributor. If they can respond they will.

darangi commented 3 years ago

@vlad0337187 Thanks for the contributions 🙇🏾

atom / ide-typescript