onDidDestroy not working - Githubissues

atom / image-view

View images in an Atom editor

MIT License

44 stars 39 forks source link

onDidDestroy not working #177

Closed jneuendorf closed 6 years ago

jneuendorf commented 6 years ago

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

onDidDestroy callbacks don't seem to get called.

Reproduces how often: 100%

Versions

atom --version Atom : 1.27.2 Electron: 1.7.15 Chrome : 58.0.3029.110 Node : 7.9.0

apm --version apm 1.19.0 npm 3.10.10 node 6.9.5 x64 atom 1.27.2 python 2.7.15 git 2.17.1

Additional Information

Searching through the repo the event did-destroy seems to never be emitted which would explain why the callbacks don't fire.