Remove global background colour variable

atom / image-view

View images in an Atom editor

MIT License

44 stars 39 forks source link

Remove global background colour variable #179

Closed Aerijo closed 6 years ago

Aerijo commented 6 years ago

My last PR added a choice for default background colour. As a global variable :unamused:.

This PR changes the value to a property of the ImageEditorView. I would have made it just local, but it might be more useful this way.

I could have moved it up to the main body of the constructor, but I don't think it really matters.

Aerijo commented 6 years ago

@lee-dohm Sorry for the ping, I think this should be merged quickly though. Who knows what a stray global can do (granted, it's only created if the user opens an image).

lee-dohm commented 6 years ago

Pretty sure this isn't a global variable because of Node's module loading and protections, so at least it is module local instead of global.

lee-dohm commented 6 years ago

Thanks for the help :tada: