atom / language-c

C support in Atom
Other
118 stars 152 forks source link

Added break to switch and case #319

Closed Kieferleiter closed 5 years ago

Kieferleiter commented 5 years ago

Requirements

Description of the Change

I added break to the switch and case, because without the break the computer wouldn't know that a case ends and would just run through everyone.

Alternate Designs

The formatting could be different for example: case(value): code break;

I choosed it this way because I always format it like this.

Benefits

You don't have to type in break; every time you create a case.

Possible Drawbacks

I don't see any in this.

Applicable Issues

rsese commented 5 years ago

Thank you very much for the contribution!

We generally don't accept modifications for snippets in the language packages since they are easily overridden and we expect that people will do so for their own purposes. We provide instructions on how to create your own snippets in the Flight Manual. And viewing a language package that provides snippets allows you and anyone else to copy the current version as a starting place for creating your own.

Thanks for the suggestion but we're going to leave things as they are for now unless the current snippet produces invalid code.