Closed jeff-hykin closed 5 years ago
Thanks for the feedback @jeff-hykin π
We've been adjusting our review process over time to help with tracking pull requests but there's of course room for improvement. Personally, I don't know if the suggested workflow would necessarily speed things up in general but I'll go ahead and share your idea with the other maintainers.
And I'll go ahead and close this out since because we treat our issues list as the Atom team's backlog, we close feedback issues after passing along the information to the maintainers to keep our backlog clean and focused.
Thanks for responding quickly! I appreciate it. That's got to be one giant backlog haha.
You guys might like this solution bit more: rather than experimental files, create an Atom extension "Experimental C++ Syntax" so that the built-in codebase doesn't get bloated.
I use VS Code, so for my own personal use I went ahead and made a VS Code extension and merged some of the pull requests myself. (link)
Prerequisites
Description
It is time consuming for Dev's to review/merge grammar changes.
Steps to Reproduce
Suggestion Solution: Can we create an
c.experimental.cson
andc++.experimental.cson
where changes are merged much more freely and the community can easily test/use all of the fixes people have pushed. It would outsource the testing problem (meaning less work for reviewers). It would also make it a lot less annoying for users who really really need a fix because one'
is screwing up the syntax of the entire file (see issue #320 which was solved in 2017 by pull request #251 and is still not merged).