atom / language-c

C support in Atom
Other
116 stars 154 forks source link

Added `noexcept` and `mutable`, removed `_Atomic` from tree-sitter-cpp #331

Closed isaacsaffold closed 5 years ago

isaacsaffold commented 5 years ago

Description of the Change

noexcept and mutable were added to storage.modifier in "tree-sitter-cpp.cson", corresponding with their presence in "c++.cson". _Atomic, which is a valid type qualifier in C but not C++, was removed from "tree-sitter-cpp.cson".

Benefits

noexcept and mutable will be highlighted correctly, and any confusion caused by _Atomic being erroneously highlighted will cease.

Ben3eeE commented 5 years ago

:wave: Thanks for contributing.

noexcept is being added in https://github.com/atom/language-c/pull/330 which brings improved support for it from the tree-sitter upgrade.

Though I realize the scopes I added for noexcept are wrong. Do you mind undoing the noexcept change here and I correct it in my PR?

isaacsaffold commented 5 years ago

I just undid it.

Ben3eeE commented 5 years ago

Thanks for contributing 🙇

isaacsaffold commented 5 years ago

No problem. Glad I could be of service.