search

atom / language-clojure

Clojure package for Atom
Other
49 stars 48 forks source link

Fix tokenization of escaped characters in regexes #55

Closed pchaigno closed 7 years ago

pchaigno commented 7 years ago

The issue with escaped characters in regular expressions was first reported in #11 and partially fixed in #14. It was reported a second time in #41 and partially "fixed" in #50. The second fix is a regression of the first fix:

This pull request fixes the grammar as well as the test for #41 and adds a new test for #11.

The regression was initially reported by @Mikechaos at github/linguist#3260.

50Wliu commented 7 years ago

Thanks for fixing this. Third time's the charm, no? I've checked this with other regex grammars and I'm pretty sure this is finally the right solution.

pchaigno commented 7 years ago

Third time's the charm, no?

I hope. I'd hate to be the third person to fail :grimacing: