search

atom / language-clojure

Clojure package for Atom
Other
49 stars 48 forks source link

Capture regexp begin/end as punctuation in Clojure syntax #66

Closed tonsky closed 7 years ago

tonsky commented 7 years ago

Description of the Change

When highlighting regexp, starting #" and ending " should be of class punctuation. That is done e.g. for strings but was forgotten for regexpes

Alternate Designs

This is a very simple change. I believe there’s only one way to do it.

Benefits

Regexpes are highlighted the same way everything else is (e.g. strings, vectors, maps).

Possible Drawbacks

None

Applicable Issues

None

50Wliu commented 7 years ago

Looks like specs need to be updated.

tonsky commented 7 years ago

I’ve updated specs

tonsky commented 7 years ago

Can you cut a release please?

50Wliu commented 7 years ago

Is there a specific reason you'd like a new release? I'm only planning to publish a new release after Atom 1.17.0 is released since this is a bundled package.

tonsky commented 7 years ago

The only reason is I want to use the stuff :) But it’s not showstopper, so please follow whatever release process you’re comfortable with. When is Atom 1.17.0 due?

50Wliu commented 7 years ago

I can't give an exact date, but probably sometime this month. If you really want to use it right now, you can install the package as a git package (pasting https://github.com/atom/language-clojure into the Install dialog in Settings View should work).

tonsky commented 7 years ago

Thanks!

On Wed, May 3, 2017 at 12:21 AM Wliu notifications@github.com wrote:

I can't give an exact date, but probably sometime this month. If you really want to use it right now, you can install the package as a git package (pasting https://github.com/atom/language-clojure into the Install dialog in Settings View should work).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/atom/language-clojure/pull/66#issuecomment-298765008, or mute the thread https://github.com/notifications/unsubscribe-auth/AARabEOdXGTvyb-2R5HAEKOgwNV0dnAAks5r155LgaJpZM4NLNPr .