search

atom / language-clojure

Clojure package for Atom
Other
49 stars 48 forks source link

Npm scripts #74

Closed chrisbroome closed 6 years ago

chrisbroome commented 6 years ago

Requirements

Update coffeelint to the latest version. Add lint npm script

Description of the Change

Update coffeelint to the latest version, v2.0.7. Add lint npm script so that there's a standard way to lint files.

Alternate Designs

None

Benefits

Possible Drawbacks

Since linting still passes, I'd say that there are no drawbacks.

Applicable Issues

None

50Wliu commented 6 years ago

Thanks for the PR. However, style doesn't really matter in this repository and the benefits of adding a dedicated linting script are next to none. Given that we're transitioning away from Coffeescript to JavaScript, I don't think these changes are necessary.

Thanks again for the effort; it's definitely appreciated :). I just think that there's not enough benefits to warrant merging this.