atom / language-coffee-script

CoffeeScript support in Atom
Other
59 stars 56 forks source link

Block comments are not necessarily multiline #150

Closed winstliu closed 7 years ago

winstliu commented 7 years ago

Requirements

Description of the Change

This removes the pattern that was forcing block comments to always be multiline. However, doing so has exposed more bugs with function tokenization breaking on comments. I'll see if it can be fixed in this PR.

Alternate Designs

N/A

Benefits

Single-line block comments will be tokenized correctly.

Possible Drawbacks

There are no drawbacks, per say, but as mentioned above this change does reveal some more underlying bugs.

Applicable Issues

Fixes #149

winstliu commented 7 years ago

At first glance, it will require an extremely substantial amount of effort to get those patterns to tokenize correctly. Merging this as it still fixes the issue.