Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
Separate function/method call matching into two categories: calls with parentheses and calls without. This prevents the grammar from starting an argument list without parentheses but then ending it with a parenthesis. This can happen, for example, when the function call is wrapped in parentheses like so: (eat food).
Alternate Designs
None.
Benefits
Argument list tokenization is now consistent: no more potential for mixed parentheses matching.
Possible Drawbacks
None.
Applicable Issues
Fixes #153
Fixes #154
Fixes #155
/cc @nathancarter: Thanks so much for the detailed issues that you created. They really helped me track down the cause of the issue, even if they weren't directly litcoffee-related. You were right that they have the same root cause :).
nathancarter
commented
7 years ago
Requirements
Description of the Change
Separate function/method call matching into two categories: calls with parentheses and calls without. This prevents the grammar from starting an argument list without parentheses but then ending it with a parenthesis. This can happen, for example, when the function call is wrapped in parentheses like so:
(eat food).Alternate Designs
None.
Benefits
Argument list tokenization is now consistent: no more potential for mixed parentheses matching.
Possible Drawbacks
None.
Applicable Issues
Fixes #153 Fixes #154 Fixes #155
/cc @nathancarter: Thanks so much for the detailed issues that you created. They really helped me track down the cause of the issue, even if they weren't directly litcoffee-related. You were right that they have the same root cause :).