search

atom / language-coffee-script

CoffeeScript support in Atom
Other
59 stars 56 forks source link

Add support for JSX tags to the CoffeeScript grammar #172

Closed cuberoot closed 5 years ago

cuberoot commented 6 years ago

Description of the Change

In CoffeeScript 2.0, JSX tags became part of the language (https://coffeescript.org/#jsx). This change adds recognition of tags and attributes to the existing CoffeeScript grammar.

Alternate Designs

No other designs were considered as this is a simple addition to an exisiting grammar.

Benefits

This change will add syntax highlighting for JSX tags and attributes in Atom.

Possible Drawbacks

A bug could cause incorrect tokenization of CoffeeScript code and cause issues in syntax highlighting

Applicable Issues

https://github.com/atom/language-coffee-script/issues/135

rsese commented 6 years ago

Thanks! Someone from the team will take a look as soon as they can.

lee-dohm commented 6 years ago

Thanks for the contribution! We're currently deciding the way forward for our official language packages with the advent of tree-sitter. We'll get back to you as soon as we can once we make some other decisions.

cuberoot commented 6 years ago

@lee-dohm Ok, thanks. Let me know either way. I could possibly contribute to a tree-sitter solution if you go that direction.