search

atom / language-csharp

C# language support for Atom
Other
62 stars 53 forks source link

Add method call highlighting #109

Closed worldbeater closed 6 years ago

worldbeater commented 6 years ago

Added method call highlighting like in Java Atom plugin https://github.com/atom/language-java/blob/master/grammars/java.cson#L827

Now C#'s method chains look rather pretty! How it was before (ugly):

image

How it is now (pretty):

image

worldbeater commented 6 years ago

@50Wliu @damieng need some help on failing tests 🤔

damieng commented 6 years ago

We actually have a plan to take the Microsoft-produced C# grammar and replace our own. I'll check in with them to find out where the tweak we needed is at.

worldbeater commented 6 years ago

Visual Studio Code C# grammar file is located in vscode official repository. It was generated using official C# syntax grammar. I've just tested that file in Atom - and it works fine, providing high-quality code highlighting. VsCode has MIT license applied, so there should be no issues with licenses.

This is how the code looks like in Atom with Microsoft's grammar:

image

So are there any other reasons for not implementing this now? If it is needed, I can pull-request with the new grammar.

Thanks, @damieng!

damieng commented 6 years ago

There are issues with entity names we're trying to sort out to avoid regressing in a very obvious area with the variety of themes.

worldbeater commented 6 years ago

Thank you very much for your work! Hope finally C# support in Github and in Atom will be as good as it is for languages like Java, Python or C++. It's so cool! 👍

Seems this pull request is no longer needed and can be closed.