search

atom / language-csharp

C# language support for Atom
Other
62 stars 53 forks source link

Use grammar from Microsoft #110

Closed damieng closed 6 years ago

damieng commented 6 years ago

Use the Microsoft-supported grammar for C# from https://github.com/dotnet/csharp-tmLanguage

damieng commented 6 years ago

Rather than wait for upstream changes to handle the storage.type.cs colorization issues made two small changes so 99% of our class names still looks right in Atom and on GitHub.com

damieng commented 6 years ago

@worldbeater thanks for nudge on this and let me know if you see any weirdness with this grammar before we ship.

damieng commented 6 years ago

Fixes #88 #93 #96 #97 #99 #100 #103 #105 #106 #107

worldbeater commented 6 years ago

Unable to detect any issues in my projects — everything works as expected. Most bugs are gone! Among them are: https://github.com/atom/language-csharp/issues/107 https://github.com/atom/language-csharp/issues/100 https://github.com/atom/language-csharp/issues/96 https://github.com/atom/language-csharp/issues/88 and many others.

image

Seems to be production-ready!

damieng commented 6 years ago

Tempted to bump the package from 0.14.x to 1.0.0 ;-)