search

atom / language-csharp

C# language support for Atom
Other
62 stars 52 forks source link

Incorrect syntax highlighting when method name has prefix and argument has /* #113

Closed ghost closed 6 years ago

ghost commented 6 years ago

Incorrect syntax highlighting:

A.Call("/*");
AfterCall();

Distilled:

image

Correct by removing A.:

Call("/*");
AfterCall();
damieng commented 6 years ago

Is this in Atom? Or for github.com ?

ghost commented 6 years ago

It's github.com, isn't GitHub linguist sharing this repo?

damieng commented 6 years ago

It is but GitHub.com is using an older version of the grammar. We're working on figuring out how to ship the new grammar on github.com - it uses some features not available there right now. Stay tuned!

ghost commented 6 years ago

Stay tuned!

Anything i can do to help/speed up fixing the blocking issues? Where to send PR, what to fix etc. while my radio is tuned. :)

damieng commented 6 years ago

Unfortunately the new grammar (in this repo) uses a lot of Oniguruma specific extensions while github.com is tied to a fork of PCRE that doesn't support them.

ghost commented 6 years ago

@damieng, thanks. I read somewhere to post C# syntax related issues to this repo, instead of GitHub/linguist. In this situation, do you think we should move this to linguist or other PCRE-based repo? Or should we try to hook up this to GitHub.com?

damieng commented 6 years ago

I summarize our options here https://github.com/atom/language-csharp/issues/112#issuecomment-379094384

damieng commented 6 years ago

This should be picked up by github.com next time they pull our grammar :)