search

atom / language-csharp

C# language support for Atom
Other
62 stars 53 forks source link

Use black color for properties #119

Closed worldbeater closed 6 years ago

worldbeater commented 6 years ago

Now uses black color for properties also. This is how it was before (inconsistent):

image

This is how it is after (uses black like fields, variables, params, etc.):

image

This is what I've forgotten to implement here, sorry (: Hope this is the final tweak, and we can keep calm and wait until linguist is released.

ghost commented 6 years ago

@worldbeater, @damieng, is there an automatic way to update the cson from upstream https://github.com/dotnet/csharp-tmLanguage/blob/master/grammars/csharp.tmLanguage.cson and apply the patches? If no, then could we use https://github.com/dotnet/csharp-tmLanguage as a submodules and apply patches (checked in .patch files)? Then we can have a prepare script at root of this repo that applies the patch git apply patches/001-some-logical-name.patch.

ghost commented 6 years ago

I am interested in changes from https://github.com/dotnet/csharp-tmLanguage/pull/117 and previous two PRs :)

damieng commented 6 years ago

The plan was to try and get the changes applied upstream but I've had very little time to work on this since I left GitHub.

ghost commented 6 years ago

The plan was to try and get the changes applied upstream

That would be great to have single source of truth. If it breaks other tm usages upstream, maybe there we can automate it using PCRE conversion script.