atom / language-csharp

C# language support for Atom
Other
62 stars 52 forks source link

C# syntax highlight glitch when using Tuple return #128

Open skyline75489 opened 5 years ago

skyline75489 commented 5 years ago

Prerequisites

The issue was found in our private repo in Github.com. I've contact Github support which leads me to linguist repo which then leads me here.

Description

The highlighter seems to falsely believe there's comment when Tuple return is used.

Steps to Reproduce

This is the minimum reproductive example I've managed to make to demostrate the issue:

public class {
    public async Task<
                (bool success,
            string content)> Func(
            ProductModel product,
            Settings settings)
    {
        req1.Headers.Add("Accept", "application/json, text/javascript, */*; q=0.01");
        req1.Headers.Add("Referer", $"{ShopBaseDomain}/shop/gd/dtl/goos.do?onlnGoosCd={goosCd}");
    }
}

Additional Information

None

skyline75489 commented 5 years ago

I've also submit an issue to upstream https://github.com/dotnet/csharp-tmLanguage/issues/154.

rsese commented 5 years ago

Thanks @skyline75489 - reproduced with 1.39.0-nightly19 on macOS 10.12.6.

csharp-bug

skyline75489 commented 4 years ago

Hi @rsese . Is this project discontinued? It has no activity for the last 2 year. Is there anything we could help to continue the work?

xihnik commented 4 years ago

+