atom / language-csharp

C# language support for Atom
Other
62 stars 53 forks source link

no coloring in function calls #63

Closed PierBover closed 7 years ago

PierBover commented 8 years ago

Is this normal?

image

Most of the code only uses one color.

50Wliu commented 8 years ago

Probably not. Does it happen with other syntax themes as well?

PierBover commented 8 years ago

Yes.

This is with the Atom Dark syntax theme (the previous screenshot was with One Dark).

image

thethreeonee commented 8 years ago

Same here.

damieng commented 7 years ago

A lot of this is by-design as the syntax highlighting can't distinguish between classes, method calls, property access and variable names because there isn't a compiler behind the scenes.

The second screenshot exhibits a separate issue where { and } in a string causes it to think the method ends in a similar way to https://github.com/dotnet/coreclr/blob/7b97c58/src/mscorlib/src/System/RtType.cs#L63

damieng commented 7 years ago

Hi, a big merge just got put in that adds some additional highlighting in various places such as constraints, generics etc. It should ship in the next beta of Atom.

I'm going to close this issue in favor of very specific instances where highlighting still doesn't happen.