search

atom / language-csharp

C# language support for Atom
Other
62 stars 52 forks source link

Heads up on ongoing effort in VSCode C# grammar and can we unify the two grammars? #80

Closed ivanz closed 7 years ago

ivanz commented 7 years ago

Hi,

There have been some substantial improvements to the C# grammar in the VSCode repo (here) and ongoing effort to build out the test coverage (here)

As such I wanted to raise your attention to this issue here: https://github.com/OmniSharp/omnisharp-vscode/issues/877 :

Appears to me that there is some ongoing duplicated effort with the C# textmate grammar in VSCode (gitlog) and Atom (gitlog).

Seems like the only real difference between the two is JSON vs CSON, so why not extract the VSCode textmate C# grammar and test harness setup into a separate repo in OmniSharp, port any fixes from Atom and then share the same grammar across the two extensions (outping CSON, etc)?

damieng commented 7 years ago

I'm on the thread for the VS Code issue tracking this - we'll continue the discussion there.