search

atom / language-gfm

GitHub Flavored Markdown in Atom
MIT License
101 stars 107 forks source link

support php by copying injections from language-php #216

Closed gkemmey closed 7 years ago

gkemmey commented 7 years ago
Before After
image image

Requirements

No new ones.

Description of the Change

Supports PHP highlighting by copying the injections (see here). This closely follows a similar solution in the language-markdown package.

Alternate Designs

Just includingtext.html.php in the patterns section didn't seem to do it. Personally, not 100% clear why.

Happy to look at better solutions, not personally sure of what they might be.

Benefits

PHP code gets highlighted.

Possible Drawbacks

Copying the injections from the language-php adds maintenance of keeping them in sync.

Applicable Issues

None that I saw.

winstliu commented 7 years ago

This will be somewhat solved by atom/language-php#292 by only including the internal PHP grammar. Going to close this for now (we can always revisit later) because the referenced PR is almost ready.