Add more scopes to the tree-sitter go grammar - Githubissues

atom / language-go

Go language package for Atom

Other

106 stars 65 forks source link

Add more scopes to the tree-sitter go grammar #158

Closed Ben3eeE closed 6 years ago

Ben3eeE commented 6 years ago

TODO

[x] default in this program does not get parsed with an anonymous node and is not highlighted
[x] true and false is not highlighted. They are constant.language.go in textmate
[ ] The % part of interpreted_string_literal is not highlighted differently. It's constant.other.placeholder.go in textmate:
```
fmt.Printf("Don't know type %T\n", t)
```
textmate: tree-sitter:
[x] Test everything

Changes

Scope go as keyword.control
Scope imaginary_literal as constant.numeric.integer
Scope float_literal as constant.numeric.float
Scope all operators as keyword.operator

/cc: @maxbrunsfeld

maxbrunsfeld commented 6 years ago

I pushed an update to tree-sitter-go that addresses some issues:

There should now be an anonymous default node, so default in switch statements should get colored.
There are now separate true and false nodes

Ben3eeE commented 6 years ago

Nice, yeah it seems like we have this problem in other languages as well. The %. Like in Python {} is not highlighted in a string /cc: https://github.com/atom/language-python/issues/281#issuecomment-434022848