Fold select, switch, case

atom / language-go

Go language package for Atom

Other

106 stars 65 forks source link

Closed Ben3eeE closed 6 years ago

Ben3eeE commented 6 years ago

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Fixes https://github.com/atom/language-go/issues/163 by adding fold rules for switch, select and case.

N/A

Can fold select switch and case

Someone wants to be unable to fold these things

/cc: @maxbrunsfeld

Ben3eeE commented 6 years ago

Edit: nevermind this doesn't make sense because then the entire else { would be on the same line as well.

While testing this I noticed that if else and if else if doesn't fold correctly:

if else

if

I would expect both cases to fold the same way but it doesn't. I have idea how to fix this.

maxbrunsfeld commented 6 years ago

📈

toasa commented 6 years ago

thank you