search

atom / language-go

Go language package for Atom
Other
106 stars 58 forks source link

Support %w verb/placeholder #178

Closed flowchartsman closed 5 years ago

flowchartsman commented 5 years ago

The %w verb is introduced into go 1.13 and is functionally an alias for %v, but adds wrapping to errors.

Description of the Change

w added to the list of placeholder characters.

Alternate Designs

n/a

Benefits

proper highlighting of a newly-valid print verb

Possible Drawbacks

conceivably people using older go versions might see a verb highlighted that won't actually work as a verb, but the odds are that if they are seeing / using %w, they are already using the correct version.

Applicable Issues

n/a

rsese commented 5 years ago

Thanks for the contribution!

As you may have heard, we are migrating from our old first-mate grammar engine to the new Tree-sitter engine. This will enable a number of new features, more consistent syntax highlighting, and better performance, among other benefits. In order to free up our limited resources, we have decided to stop maintaining the first-mate grammar when there is a built-in Tree-sitter grammar available.

Since this pull request is specific to the first-mate grammar we're going to close it, but thanks again for the contribution.

flowchartsman commented 5 years ago

Could you pretty please commit this? It's a tiny change, VSCode Go support builds its grammar based on this, and it would allow this new verb to be supported in the interim.