Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
I updated patterns that relate to storage types to include underscore wherever it was missing; also updated variable pattern to capture storage types with underscore.
Added unit test.
Alternate Designs
No alternative designs were considered.
Benefits
Fixes issue of having package and class names that start with underscore.
Possible Drawbacks
I had to comment out line 832 in java-spec.coffee, "_1" value is now highlighted as storage.type.java. I will open issue to fix this later. Should not affect anything else, as far as I am concerned.
Requirements
Description of the Change
I updated patterns that relate to storage types to include underscore wherever it was missing; also updated variable pattern to capture storage types with underscore.
Added unit test.
Alternate Designs
No alternative designs were considered.
Benefits
Fixes issue of having package and class names that start with underscore.
Possible Drawbacks
I had to comment out line 832 in
java-spec.coffee, "_1" value is now highlighted asstorage.type.java. I will open issue to fix this later. Should not affect anything else, as far as I am concerned.Applicable Issues
Fixes #198