Fix Javadoc @link tag highlighting broken issue

atom / language-java

Java package for Atom

Other

62 stars 58 forks source link

Fix Javadoc @link tag highlighting broken issue #206

Closed CsCherrYY closed 4 years ago

CsCherrYY commented 5 years ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

This PR uses a non-greedy match instead of a greedy match in the highlighting. This change may bring correct highlighting in the Javadoc @link tag when more than one @link tag in the same line.

Alternate Designs

It is a simple fix so no alternate designs were considered.

Benefits

Fix Javadoc @link tag highlighting broken problem.

Possible Drawbacks

None.

Applicable Issues

#958

sadikovi commented 5 years ago

Your PR breaks the test for link, can you have a look why it fails?

CsCherrYY commented 5 years ago

Your PR breaks the test for link, can you have a look why it fails?

OK. But the fix seems to work well in VS Code. Could you tell me how can I do the tests myself?

sadikovi commented 5 years ago

You can run apm test to run the tests in the repository. You can also have a look at Atom Flight Manual, for example, https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.

I would suggest adding a new test for your changes with multiple link tags in the javadoc.

CsCherrYY commented 5 years ago

You can run apm test to run the tests in the repository. You can also have a look at Atom Flight Manual, for example, https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.

I would suggest adding a new test for your changes with multiple link tags in the javadoc.

I think it is inappropriate in the original test of java-spec.coffee in line 2553, label {@link Class#method()}} , so I deleted the extra brace and add the multiple @link tags test.