atom / language-java

Java package for Atom
Other
62 stars 58 forks source link

Comments should not end 'keyword.control.new.java' #210

Closed Vigilans closed 4 years ago

Vigilans commented 4 years ago

Description of the Change

Currently, the divide operator ('/') will end 'keyword.control.new.java' scope. But ('/') could also be the beginning of a comment, and it should not end the scope.

Alternate Designs

No alternative considered.

Benefits

Comment would not affect the highlighting of inner class, as described in #209.

Possible Drawbacks

Nothing as far as I know.

Applicable Issues

Fix #209

sadikovi commented 4 years ago

Can you add a test case for this change?

Vigilans commented 4 years ago

@sadikovi Unit test is added.