search

atom / language-java

Java package for Atom
Other
62 stars 58 forks source link

Scope variables in expressions #221

Open JacksonKearl opened 4 years ago

JacksonKearl commented 4 years ago

Summary

It would be helpful to add a scope to the textmate grammar denoting variable read/write access. For example in typescript, the scope variable.other.readwrite is applied.

Motivation

Currently the only scope given to variable read/write access is source.java, which means users and themes cannot configure the appearance of these accesses in themes.

Additional context

Screen Shot 2020-01-19 at 4 12 55 PM

https://www.reddit.com/r/vscode/comments/equyio/im_using_the_horizon_theme_in_vscode_why_do_local/

sadikovi commented 4 years ago

No, we don't do that currently. Can you give examples when it is useful?

JacksonKearl commented 4 years ago

Currently the only scope given to variable read/write access is source.java, which means users and themes cannot configure the appearance of variable uses in themes.

Many themes attempt to control variable colors, and they should be able to work in Java in addition to other languages.

sadikovi commented 4 years ago

Okay, makes sense. I am a bit snowed under at the moment due to bunch of other open-source work, would appreciate a pull request :).