Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
This PR removes usage of variable.other.property.java, replaces it with variable.other.object.property.java.
Having variable.other.property.java does not make sense since there is no property call without an object/instance. This change unifies object with properties in terms of scope, see below:
Before
object.property1.property2
// would result in
// object => [variable.other.object.java]
// property1 => [variable.other.object.property.java]
// property2 => [variable.other.property.java]
After
object.property1.property2
// would result in
// object => [variable.other.object.java]
// property1 => [variable.other.object.property.java]
// property2 => [variable.other.object.property.java]
The same is applicable for object.property:
Before:
Makes the grammar consistent, all properties get scope variable.other.object.property.java. Allows syntax highlighting to rely on the fact that all properties will have this scope.
Possible Drawbacks
Could potentially break syntax highlighting that relies on separation between trailing and non-trailing properties.
Requirements
Description of the Change
This PR removes usage of
variable.other.property.java
, replaces it withvariable.other.object.property.java
.Having
variable.other.property.java
does not make sense since there is no property call without an object/instance. This change unifies object with properties in terms of scope, see below:Before
After
The same is applicable for
object.property
: Before:After:
Alternate Designs
None were considered.
Benefits
Makes the grammar consistent, all properties get scope
variable.other.object.property.java
. Allows syntax highlighting to rely on the fact that all properties will have this scope.Possible Drawbacks
Could potentially break syntax highlighting that relies on separation between trailing and non-trailing properties.
Applicable Issues
Closes #224