atom / language-java

Java package for Atom
Other
62 stars 58 forks source link

GitHub Actions #238

Open aminya opened 3 years ago

aminya commented 3 years ago

Description of the change

Use GitHub Actions instead of Travis and Appveyor.

Benefits

Verification

The CI passes: https://github.com/aminya/language-java/actions/runs/359820773

Drawbacks

none

Release Notes

N/A

sadikovi commented 3 years ago

Hello. Thanks for opening a pull request. I would like to understand the changes. Why is it necessary to update the CI?

The current CI:

Would like to know if there is an existing precedent, e.g. other atom language repos have migrated to github actions.

aminya commented 3 years ago

Hello. Thanks for opening a pull request. I would like to understand the changes. Why is it necessary to update the CI?

Hi. I mentioned the reasons for this change in the above post:

Extra points:

The current CI:

  • Is pretty fast anyway. Multiple PRs can also run parallel builds.
  • We do not configure CI very often.

I know, but it needs to be updated at some point.

My PRs to language-* packages all fail because Travis is outdated. See this for an example: https://github.com/atom/language-python/pull/325

  • Travis continues to remain free for open-source projects, albeit with new limitations.

But Atom is a GitHub product, it is hosted on GitHub. It is much more natural to use something from GitHub itself.

Would like to know if there is an existing precedent, e.g. other atom language repos have migrated to github actions.

An example of a project that currently use it: https://github.com/atom/github

I use GitHub Actions in all the projects at @atom-ide-community, so we have battle-tested these in our organization.

I have opened PRs for a dozen of the language repos.

Details ![image](https://user-images.githubusercontent.com/16418197/99884122-46cec200-2bf1-11eb-9d3d-873f4d30cb7c.png)