Java tree-sitter grammar does not consistently highlight constants - Githubissues

atom / language-java

Java package for Atom

Other

62 stars 58 forks source link

Java tree-sitter grammar does not consistently highlight constants #240

Closed sadikovi closed 3 years ago

sadikovi commented 3 years ago

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

For some reason, constants are highlighted differently in java tree-sitter grammar. Here is an example:

conf.set(S3_CLIENT_FACTORY_IMPL, "Test");
conf.set(ENDPOINT, "test-endpoint");

S3_CLIENT_FACTORY_IMPL is not highlighted but ENDPOINT is.

This is due to numbers not being in the pattern. If you remove 3 from S3_CLIENT_FACTORY_IMPL, everything works correctly.

Expected behavior:

S3_CLIENT_FACTORY_IMPL is being highlighted as ENDPOINT.

Actual behavior:

The opposite.

Reproduces how often:

100%

Versions

Additional Information