module name and comments not highlighted in module-info.java

atom / language-java

Java package for Atom

Other

62 stars 59 forks source link

module name and comments not highlighted in module-info.java #245

Open Eskibear opened 3 years ago

Eskibear commented 3 years ago

Description

Also reported in https://github.com/redhat-developer/vscode-java/issues/1384 JEP reference about module system: https://openjdk.java.net/jeps/261

Expected behavior:

com.foo.bar and java.base should be highlighted.
comments in Line 4 should be hightlighted.

Versions

it's tested on vscode@1.53.0-insiders, should be latest release of atom/language-java

Eskibear commented 3 years ago

@sadikovi Can you take a look please? FYI that we might be able to work "module names" around via semantic highlighting. So comments part should have a higher priority if you are short of bandwidth...

Eskibear commented 3 years ago

I just created a PR against the comments part. please take a look.

sadikovi commented 3 years ago

Shall we close this issue or is there anything else left to do?

Eskibear commented 3 years ago

com.foo.bar and java.base should be highlighted.

It would be better if qualified module names can be highlighted.