Allman-style ES6 method definitions not recognized

atom / language-javascript

JavaScript language package for Atom

Other

194 stars 235 forks source link

Allman-style ES6 method definitions not recognized #361

Open winstliu opened 8 years ago

winstliu commented 8 years ago

es6()  //<-- meta.function-call.js
{
}

es6() {}  //<-- meta.function.method.definition.js

MitchLillie commented 6 years ago

I believe this actually applies to all Allman-style braces, not only the ES6 method definitions:

screen shot 2018-02-05 at 11 10 33 am

Any update on this? I'm happy to take a stab at a PR if it's not currently in development.

winstliu commented 6 years ago

Go for it.

MitchLillie commented 6 years ago

@50Wliu OK, I will dive a bit deeper. Do you have any tips that might point me in the right direction, for example which object and/or property I'm looking at in javascript.cson, or which test I could expand to include this new case?

winstliu commented 6 years ago

Looking at your examples I don't actually see what you're seeing except for the ES6 case (braces colored green for emphasis). allman-function-definitions

Can you make sure you're running the latest version of Atom, currently 1.23.3?