atom / language-javascript

JavaScript language package for Atom
Other
194 stars 235 forks source link

Shorthand jsx fragments break syntax highlighting #665

Open James-Reed-cognito opened 5 years ago

James-Reed-cognito commented 5 years ago

Prerequisites

I'm unsure that any of the above apply as this is based on an issue I'm having with GitHub, not the atom client itself.

Description

When looking at a PR that includes jsx, syntax highlighting fails after a closing bracket for a shorthand jsx fragment is included.

Steps to Reproduce

  1. Create a PR with jsx changes including a shorthand jsx fragment (ie <></>) on GitHub
  2. See that syntax highlighting for the jsx file fails after the ending bracket

Expected behavior:

Syntax highlighting should continue normally after the fragment shorthand

Actual behavior:

Syntax highlighting breaks after the fragment shorthand

Reproduces how often:

100%

Versions

Unsure, I was directed here from https://github.com/github/linguist#theres-a-problem-with-the-syntax-highlighting-of-a-file

Additional Information

N/A

James-Reed-cognito commented 4 years ago

Hi, I submitted this over two weeks ago, would I be able to get a response, please? 🙂

lee-dohm commented 4 years ago

Thanks for reaching out. We get to everything as quickly as we can but we have a bit of a backlog that we're working through. When we get a chance, we'll take a closer look here. Thanks for understanding.

James-Reed-cognito commented 4 years ago

Hi @lee-dohm thank you for responding! I understand - is there anything I can do to help this issue be resolved more quickly?